fix(trie): Fix trie_reverts not returning sorted nodes #19280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a more future-proof fix, I've also made the fields of the TrieNodesSorted struct private, and introduced a constructor which will do a debug_assert that the input is already sorted.
mediocregopher
added
C-bug
mediocregopher
commented
Oct 24, 2025
| } | ||
|
|
||
| Ok(trie_updates) | ||
| Ok(TrieUpdatesSorted::new(account_nodes, storage_tries)) |
Collaborator
Author
There was a problem hiding this comment.
This case does not require explicit sorting, as the vecs are constructed in sorted order inherently thanks to the DB
mediocregopher
requested review from
Rjected,
joshieDo,
rakita and
shekhirin
as code owners
Rjected
approved these changes
Oct 24, 2025
Member
Rjected
left a comment
Rjected
left a comment
There was a problem hiding this comment.
makes sense to me, just have a doc nit
DaniPopes
approved these changes
Oct 24, 2025
yongkangc
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a more future-proof fix, I've also made the fields of the TrieNodesSorted struct private, and introduced a constructor which will do a debug_assert that the input is already sorted.